Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docz-core): expose filtered env variables #140

Merged
merged 5 commits into from
Jul 30, 2018
Merged

feat(docz-core): expose filtered env variables #140

merged 5 commits into from
Jul 30, 2018

Conversation

lupuszr
Copy link

@lupuszr lupuszr commented Jul 13, 2018

Description

Add dotenv to support reading .env files
Expose env varables to browser which start with
REACT_APP_
ANGULAR_APP_
VUE_APP_
NODE_

Review

  • Check the copy
  • ...
  • ...

Pre-merge checklist

  • ...
  • ...

Screenshots

Before After
Image Image

lupuszr added 2 commits July 13, 2018 20:03
Add dotenv to support reading .env files
Expose env varables to browser which start with
REACT_APP_
ANGULAR_APP_
VUE_APP_
NODE_Add dotenv
@pedronauck pedronauck changed the base branch from master to dev July 13, 2018 18:43

// https://github.com/bkeepers/dotenv#what-other-env-files-can-i-use
const dotenvFiles = [
`$dotenv}.${NODE_ENV}.local`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing { here after $

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 Sure

@@ -0,0 +1,88 @@
import fs from 'fs'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, move this file inside to src/config to be together with the paths.ts file...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedronauck pedronauck changed the base branch from dev to feat/env-config July 30, 2018 05:52
@pedronauck pedronauck merged commit 0d63e0f into doczjs:feat/env-config Jul 30, 2018
pedronauck added a commit that referenced this pull request Jul 30, 2018
* feat(docz-core): expose filtered env variables (#140)

* refactor(docz-core): support for env config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants